Conversation
|
friendly ping @mtarld |
|
|
||
| .. _`components-property-info-type-builtin`: | ||
|
|
||
| ``Type::getBuiltInType()`` |
There was a problem hiding this comment.
All of these methods are kind of removed:
getBuiltinTypeis the same asgetTypeIdentifierofBuiltinTypeandObjectTypeisNullablestill existsgetClassNameonly exists onObjectTypeisCollectionis the equivalent of$type instanceof CollectionTypegetCollection[Key|Value]Typesis the same asgetCollection[Key|Value]TypeofCollectionType
The Type of TypeInfo is really different from the one from PropertyInfo, so I think we might rewrite that part completely.
Or maybe redirect to the doc related to TypeInfo's Type?
There was a problem hiding this comment.
Thanks, I missed those differences.
Maybe we can remove this part from PropertyInfo Type doc as the class is deprecated and update TypeInfo doc with appropriate methods ?
There was a problem hiding this comment.
I would also not mix the TypeInfo things into the doc of PropertyInfo
Co-authored-by: Oskar Stark <oskarstark@googlemail.com> Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
| private $builtinType => string(6) "string" | ||
| private $nullable => bool(false) | ||
| private $class => NULL | ||
| private $collection => bool(false) | ||
| private $collectionKeyType => NULL | ||
| private $collectionValueType => NULL |
There was a problem hiding this comment.
This is not what the Type class (from type-info) contains.
|
@MrYamous will you have time to finsih this? Thanks! |
On my way |
| NullableType { | ||
| - type: BuiltinType(string) | ||
| - types: [ | ||
| BuiltinType(null), | ||
| BuiltinType(string), | ||
| ] |
There was a problem hiding this comment.
I'm not sure about how to represent this in documentation
5 participants
Fixes #20799